Skip to content

legcord: update to 1.1.4 #28335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025
Merged

legcord: update to 1.1.4 #28335

merged 1 commit into from
May 19, 2025

Conversation

akierig
Copy link
Contributor

@akierig akierig commented May 5, 2025

Description

legcord: update to 1.1.3

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 15.4.1 24E263 arm64
Xcode 16.3 16E140

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@akierig akierig marked this pull request as ready for review May 5, 2025 03:09
@akierig akierig force-pushed the legcord-1.1.3 branch 5 times, most recently from a1fbffd to f20d1e0 Compare May 5, 2025 22:57
@akierig
Copy link
Contributor Author

akierig commented May 5, 2025

for whatever reason, the CI machine isn't dropping the port that NodeJS uses as part of its compile process. It's a randomly selected port and I can't find anywhere in the upstream that where it's getting invoked. Conversations with upstream maintainers suggest this is a dependency throwing the problem that is out of their hands. Open to any and all suggestions.

@akierig akierig changed the title legcord: update to 1.1.3 legcord: update to 1.1.4 May 19, 2025
@akierig
Copy link
Contributor Author

akierig commented May 19, 2025

for whatever reason, the CI machine isn't dropping the port that NodeJS uses as part of its compile process. It's a randomly selected port and I can't find anywhere in the upstream that where it's getting invoked. Conversations with upstream maintainers suggest this is a dependency throwing the problem that is out of their hands. Open to any and all suggestions.

once again, the port builds fine locally on multiple machines.

@jmroot jmroot force-pushed the legcord-1.1.3 branch 4 times, most recently from abde205 to 5a1c9c8 Compare May 19, 2025 20:06
@jmroot
Copy link
Member

jmroot commented May 19, 2025

Seems similar to louislam/dockge#353 but the workaround used there doesn't seem applicable, since there doesn't seem to be an existing socket anywhere on the system when the port build starts.

@jmroot jmroot merged commit f80bb75 into macports:master May 19, 2025
1 of 3 checks passed
@jmroot
Copy link
Member

jmroot commented May 19, 2025

Guess we'll see how that goes on the buildbot.

@akierig akierig deleted the legcord-1.1.3 branch May 19, 2025 22:22
@akierig
Copy link
Contributor Author

akierig commented May 19, 2025

Guess we'll see how that goes on the buildbot.

seems to be fine? https://build.macports.org/builders/ports-14_arm64-builder/builds/56893

@akierig akierig mentioned this pull request May 28, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants